fix: [ejs] Upgrade ejs from 1.0.0 to 3.1.10 to resolve CVE-2022-29078 - #282
Open
hannahhuh-cog wants to merge 1 commit into
Open
hannahhuh-cog wants to merge 1 commit into
hannahhuh-cog wants to merge 1 commit into
Conversation
Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the direct dependency
ejs1.0.0->3.1.10(package.json + package-lock.json) to remediate the High (CVSS 9.8) server-side template injection / RCE vulnerability flagged by the scheduled Snyk SCA scan.Vulnerability
settings[view options][outputFunctionName]ejs@1.0.0(direct dependency)3.1.7; upgraded to3.1.10, which also covers CVE-2017-1000228 (npm:ejs:20161128) in the same package.Risk: attacker-controlled render options could inject arbitrary JavaScript executed on the server.
Compatibility note:
app.jsregisters.ejsviews throughejs-locals, which bundles its own nestedejs; the top-levelejspackage is only reached viaconsolidate. Snyk's breakability check flags v1 -> v3 as a major API change (filters removed,includesyntax changed), so if any.ejstemplate is later rendered with the top-level package, itsinclude/ filter syntax must be migrated.Verification:
require('ejs')resolves3.1.10;app.jsloads all modules without resolution errors (only expected MongoDB/MySQL connection failures).Snyk scan reference: Snyk MCP SCA scan of
COG-GTM/nodejs-goofon 2026-09-14 (org9e26acce-22c7-4efc-b470-21d9587f49fe).Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/387468bb0c6d4d6dbb7183fbbb24385f
Open in Devin Desktop: https://app.devin.ai/desktop/session/387468bb0c6d4d6dbb7183fbbb24385f?variant=devin
Requested by: @hannahhuh-cog